Skip to content

Updating changelog#640

Merged
FriederikeHanssen merged 2 commits intonf-core:devfrom
asp8200:extend_output_from_snpeff
Jul 16, 2022
Merged

Updating changelog#640
FriederikeHanssen merged 2 commits intonf-core:devfrom
asp8200:extend_output_from_snpeff

Conversation

@asp8200
Copy link
Copy Markdown
Contributor

@asp8200 asp8200 commented Jul 16, 2022

Just updating the changelog

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@asp8200 asp8200 requested a review from maxulysse as a code owner July 16, 2022 19:48
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 16, 2022

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit eebb30c

+| ✅ 145 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   1 tests had warnings |!
Details

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version badge.

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-07-16 19:49:14

@FriederikeHanssen FriederikeHanssen merged commit a651dc1 into nf-core:dev Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants